Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the environment docs with the database and extension #1188

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Apr 20, 2021

updated the environment docs with the database and extension
Signed-off-by: Harshad Reddy Nalla [email protected]

Related Issues and Dependencies

Related-to:
#726
#725

Does this require new deployment ?

Not needed

Description

document update with information on how to add extension to database.

@sesheta sesheta requested review from fridex and pacospace April 20, 2021 20:03
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 20, 2021
docs/environments.md Outdated Show resolved Hide resolved
docs/environments.md Outdated Show resolved Hide resolved
docs/environments.md Outdated Show resolved Hide resolved
docs/environments.md Outdated Show resolved Hide resolved
docs/environments.md Outdated Show resolved Hide resolved
@harshad16
Copy link
Member Author

Ready for review again.

Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 💯 👏🏼

List of installed extensions
Name | Version | Schema | Description
--------------------+---------+------------+-----------------------------------------------------------
amcheck | 1.0 | public | functions for verifying relation integrity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this somethign we have declared in some yaml? or can put to a file in a repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can set this from a component that talks to storage.
so we will have this in init-job, so some newly setup their environment can benefit from it.

@goern
Copy link
Member

goern commented Apr 21, 2021

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2021
@harshad16
Copy link
Member Author

/approve

@sesheta
Copy link
Member

sesheta commented Apr 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2021
@sesheta sesheta merged commit bf37f83 into thoth-station:master Apr 22, 2021
goern pushed a commit to goern/thoth-application that referenced this pull request Jun 7, 2021
@harshad16 harshad16 deleted the db-docs branch October 20, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants